|
|
发表于 2006-4-22 01:51:59
|
显示全部楼层
bug report
1. in utils/main/main.c
while ((c = getopt (argc, argv, "e:dc:h")) != -1)
we don't support "-v" option, but you can see it in help.
while ((c = getopt (argc, argv, "e:dc:vh")) != -1)
2. if you run binary/skyeye -v
program will run switch()
default:
abort();
but we have already tcsetattr (0, TCSANOW, &tmp); so you will not get the echo.
so case '?' and default, both of them are wrong.
please goto exit_skyeye;
3.
extern machine_config_t arm_machines[];
static void display_all_support(){
int i;
fprintf (stderr,
"------------------------- Architecture and cpu supported by SkyEye---------------------------\n");
fprintf (stderr, "---- arm architecture\n");
for(i = 0; i < 17; i++)
fprintf(stderr, "%s \n",arm_machines.machine_name);
fprintf (stderr, "---- BlackFin architecture\n");
for(i = 0; i < 1; i++)
fprintf(stderr, "%s \n",bfin_cpu.cpu_name);
}
if I write program I will never write i< 17 or i< 1
I know we just declared arm_machines array here, compiler can't get the size of it, so it is impossible to use sizeof, but we can write { NULL, NULL...} in the array and then test whether we are there.
OK?
Although before I browse the program I think skyeye is a famous program, but it looks not.
This is my first glance and my feeling, but I believe its function is hugh.
Hope you do better! |
|
IP卡
狗仔卡
显身卡
;